Skip to content

Constify Rect #21905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Constify Rect #21905

wants to merge 1 commit into from

Conversation

@ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Nov 21, 2025 •
edited
Loading

Objective

None of Rect's methods are const, but they can be.

Solution

Make them const.

Testing

The tests in the rect module still pass.

@ickshonpe ickshonpe added A-Math Fundamental domain-agnostic mathematical operations S-Needs-Review Needs reviewer attention (from anyone!) to move forward D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes labels Nov 21, 2025
@ickshonpe ickshonpe mentioned this pull request Nov 21, 2025
Closed
3 tasks
@ickshonpe ickshonpe added the X-Contentious There are nontrivial implications that should be thought through label Nov 21, 2025
@ickshonpe
Copy link
Contributor Author

ickshonpe commented Nov 21, 2025 •
edited
Loading

Realised this might be stupid, glam's functions aren't const because of all the simd optimisations?
I'm not sure though, Rect isn't normally used in such a way that makes those kind of optimisations meaningful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-Math Fundamental domain-agnostic mathematical operations D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes S-Needs-Review Needs reviewer attention (from anyone!) to move forward X-Contentious There are nontrivial implications that should be thought through

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ickshonpe